Addresses four reviewer findings in the benchmark scripts added by the GROUP BY optimization PR.

Changes

backend/tests/benchmark_closure_status.py

• Removed unused imports: get_db, ClosureService, patch, MagicMock, sys, os
• Removed sys.path.insert(0, os.path.abspath('.')) — unnecessary when running via python -m
• Fixed seed_data() to satisfy all non-null FK constraints: creates a Jurisdiction row first, then populates Grievance.severity, current_jurisdiction_id, assigned_authority, and sla_deadline

backend/tests/test_closure_status_benchmark.py

• Removed unused sys and os imports
• Moved create_engine, create_all, and sessionmaker setup inside run_benchmark() — previously at module scope, causing DB creation as a side effect during pytest collection

# Before: executed at import time
engine = create_engine('sqlite:///:memory:', ...)
Base.metadata.create_all(bind=engine)

# After: scoped to the benchmark function
def run_benchmark():
    engine = create_engine('sqlite:///:memory:', ...)
    Base.metadata.create_all(bind=engine)
    TestingSessionLocal = sessionmaker(..., bind=engine)

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📝 Documentation update
• 🎨 Code style update (formatting, renaming)
• ♻️ Refactoring (no functional changes)
• ⚡ Performance improvement
• ✅ Test update

Related Issue

Closes #

Testing Done

• Tested locally
• Added/updated tests
• All tests passing

Screenshots (if applicable)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published

Co-Authors

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Summary by cubic

Optimize closure status queries by aggregating results with SQL GROUP BY. Speeds up closure count views and updates benchmarks to seed valid data and avoid module-level DB side effects.

• Performance

  • Consolidates multiple COUNTs into one grouped query.
  • Fewer DB round-trips; lower CPU on list/dashboard views.
  • No change to API responses or data shape.

• Bug Fixes

  • Removed unused imports and mocks in benchmark tests.
  • Seeded Jurisdiction and required Grievance fields (severity, current_jurisdiction_id, assigned_authority, sla_deadline).
  • Moved SQLite setup into run_benchmark() to prevent pytest collection side effects.

^{Written for commit 62206ab. Summary will update on new commits.}